Update 16-progressive-web-apps.mdx #70400
Open
+27
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code in the original doc is not valid typescript because window.PushSubscription is mixed up with webpush.PushSubscription from 'web-push'. I checked in possible fixes (and old code commented out- should be removed when accepted in main branch).
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
ijjk
reviewed
Sep 24, 2024
| JSON.stringify({ | ||
| title: 'Test Notification', | ||
| body: message, | ||
| icon: '/icon.png', | ||
| }) | ||
| ) | ||
| // old, but a type bug because PushSubscription from client is mixed up with webpush.PushSubscription which is required by webpush.sendNotification(): |
There was a problem hiding this comment.
If this is invalid we should remove it and not leave it around
ijjk
reviewed
Sep 24, 2024
| @@ -251,7 +251,10 @@ function PushNotificationManager() { | |||
| ), | |||
| }); | |||
| setSubscription(sub); | |||
| await subscribeUser(sub); | |||
| // TODO The following old line is a bug because subscribeUser is a server function and may only receive plain objects | |||
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code in the original doc is not valid typescript because window.PushSubscription is mixed up with webpush.PushSubscription from 'web-push'. I checked in possible fixes (and old code commented out- should be removed when accepted in main branch).