Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stitch errors #70393

Draft
wants to merge 5 commits into
base: canary
Choose a base branch
from
Draft

stitch errors #70393

wants to merge 5 commits into from
+553 −93

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Sep 24, 2024

No description provided.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. tests Turbopack Related to Turbopack with Next.js. type: next labels Sep 24, 2024
@huozhi huozhi mentioned this pull request Sep 24, 2024
Merged
@huozhi Graphite App
Copy link
Member Author

huozhi commented Sep 24, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @huozhi and the rest of your teammates on Graphite Graphite

@huozhi huozhi mentioned this pull request Sep 24, 2024
Merged
@ijjk
Copy link
Member

ijjk commented Sep 24, 2024 •
edited
Loading

Failing test suites

Commit: 69801e4

__NEXT_EXPERIMENTAL_PPR=true pnpm test-dev test/development/app-dir/dynamic-error-trace/index.test.ts (PPR)

  • app dir - dynamic error trace > should show the error trace
Expand output

● app dir - dynamic error trace › should show the error trace

expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `app dir - dynamic error trace should show the error trace 1`

- Snapshot  - 8
+ Received  + 0

- ReactDevOverlay
- ../src/client/components/react-dev-overlay/app/hot-reloader-client.tsx
- assetPrefix
- ../src/client/components/app-router.tsx
- actionQueue
- ../src/client/components/app-router.tsx
- AppRouter
- ../src/client/app-index.tsx

  37 |       .join('\n')
  38 |
> 39 |     expect(normalizeStackTrace(stackFramesContent)).toMatchInlineSnapshot(
     |                                                     ^
  40 |       isReactExperimental
  41 |         ? `
  42 |       "ReactDevOverlay

  at Object.toMatchInlineSnapshot (development/app-dir/dynamic-error-trace/index.test.ts:39:53)

Read more about building and testing Next.js in contributing.md.

pnpm test-dev test/e2e/app-dir/app-middleware/app-middleware.test.ts

  • app-dir with middleware > should filter correctly after middleware rewrite
Expand output

● app-dir with middleware › should filter correctly after middleware rewrite