Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Set busboy defParamCharset to utf8 #70348

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

jaredhan418
Copy link

Fixing a bug

Fix #70335

What?

see #70335

Why?

How?

As for fetch standard, I think it should make filename decode with utf-8 by default https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#constructing-form-data-set

@jaredhan418 jaredhan418 changed the title Set busboy defParamCharset to utf8 Fix: Set busboy defParamCharset to utf8 Sep 23, 2024
@ijjk
Copy link
Member

ijjk commented Sep 23, 2024

Allow CI Workflow Run

  • approve CI run for commit: d34cce1

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, could we add a regression test for this to verify it resolves the issue?

@jaredhan418
Copy link
Author

jaredhan418 commented Sep 25, 2024

Hi, could we add a regression test for this to verify it resolves the issue?

create a test file named action-handler.test.ts at same place ?
Or inside test/e2e/app-dir/actions/app/form/page.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get garbled code in Server actions if formdata contains not latin1 characters
2 participants