Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): update opentelemetry docs #70271

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

AnaTofuZ
Copy link
Contributor

@AnaTofuZ AnaTofuZ commented Sep 20, 2024

What?

https://nextjs.org/docs/app/building-your-application/optimizing/open-telemetry is partially outdated.

Why?

  • As mentioned here, SEMRESATTRS_SERVICE_NAME has been deprecated.
  • Also, the default ESLint configuration generated by create-next-app triggers warnings about the import order.

How?

  • so it has been changed to ATTR_SERVICE_NAME.
  • Also, fixed the import order.

- As mentioned [here](https://github.com/open-telemetry/opentelemetry-js/blob/cdfefb829441f0c2765756d61078c39531c04d05/semantic-conventions/src/resource/SemanticResourceAttributes.ts#L649-L656), SEMRESATTRS_SERVICE_NAME has been deprecated, so it has been changed to ATTR_SERVICE_NAME.
- Also, fixed the import order warnings that occur with the default ESLint configuration generated by create-next-app.
@ijjk ijjk added the Documentation Related to Next.js' official documentation. label Sep 20, 2024
@ijjk
Copy link
Member

ijjk commented Sep 20, 2024

Allow CI Workflow Run

  • approve CI run for commit: 5563074

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk ijjk merged commit 5c793bc into vercel:canary Sep 23, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Related to Next.js' official documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants