Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Turbopack] Introduce VcOperation that wraps operations #70242

Open
wants to merge 4 commits into
base: canary
Choose a base branch
from
Open

[Turbopack] Introduce VcOperation that wraps operations #70242

wants to merge 4 commits into from

Conversation

sokra
Copy link
Member

@sokra sokra commented Sep 19, 2024 •
edited
Loading

What?

Introduce VcOperation that wraps operations

only expose VcOperation into JS to connect to the whole compution (and be strongly consistent with the whole compuation).

also fix query string

Why?

We want operations to be strongly consistent to the whole operation. Also HMR subscribtions should include the whole entrypoints and endpoint operation. The VcOperation type makes it easy to track that and enforces connecting to the operation correctly.

In regards of the ResolvedVc work, we also want operations to be explicit.

@ijjk ijjk added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Sep 19, 2024
@sokra Graphite App
Copy link
Member Author

sokra commented Sep 19, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sokra and the rest of your teammates on Graphite Graphite

This was referenced Sep 19, 2024
Open
Closed
@sokra sokra marked this pull request as ready for review September 19, 2024 07:50
@sokra sokra changed the title Introduce VcOperation that wraps operations [Turbopack] Introduce VcOperation that wraps operations Sep 19, 2024
@sokra sokra requested a review from bgw September 19, 2024 07:54
@ijjk
Copy link
Member

ijjk commented Sep 19, 2024 •
edited
Loading

Failing test suites

Commit: 644f5a9

pnpm test test/integration/amp-export-validation/test/index.test.js

  • AMP Validation on Export > production mode > should have shown errors during build
Expand output

● AMP Validation on Export › production mode › should have shown errors during build

expect(received).toMatch(expected)

Expected pattern: /error.*The mandatory attribute 'height' is missing in tag 'amp-video'\./
Received string:  "  ▲ Next.js 15.0.0-canary.159
  - Experiments (use with caution):
    · amp·
   Checking validity of types ...
   Creating an optimized production build ...
 ✓ Compiled successfully
   Collecting page data ...
   Generating static pages (0/8) ...
   Generating static pages (2/8)··
Failed to build /dog after 1 attempts.
Failed to build /third after 1 attempts.
 ⚠ Linting is disabled.·
Error occurred prerendering page \"/dog\". Read more: https://nextjs.org/docs/messages/prerender-error·
AssertionError: Assertion failed: WebAssembly is uninitialized

  at new module$contents$goog$asserts_AssertionError (../evalmachine.<anonymous>:103:1441)
  at module$contents$goog$asserts_doAssertFailure (../evalmachine.<anonymous>:104:354)
  at goog.asserts.assertExists (../evalmachine.<anonymous>:105:374)
  at Object.module$contents$amp$validator_validateString [as validateString] (../evalmachine.<anonymous>:2245:108)
  at Validator.validateString (../packages/next/dist/compiled/amphtml-validator/index.js:17:2057)
  at validateAmp (../packages/next/dist/export/routes/pages.js:89:34)
  at async exportPagesPage (../packages/next/dist/export/routes/pages.js:106:13)
  at async exportPageImpl (../packages/next/dist/export/worker.js:202:16)
  at async Span.traceAsyncFn (../packages/next/dist/trace/trace.js:157:20)·
  Error occurred prerendering page \"/third\". Read more: https://nextjs.org/docs/messages/prerender-error·
  AssertionError: Assertion failed: WebAssembly is uninitialized
  at new module$contents$goog$asserts_AssertionError (../evalmachine.<anonymous>:103:1441)
  at module$contents$goog$asserts_doAssertFailure (../evalmachine.<anonymous>:104:354)
  at goog.asserts.assertExists (../evalmachine.<anonymous>:105:374)
  at Object.module$contents$amp$validator_validateString [as validateString] (../evalmachine.<anonymous>:2245:108)
  at Validator.validateString (../packages/next/dist/compiled/amphtml-validator/index.js:17:2057)
  at validateAmp (../packages/next/dist/export/routes/pages.js:89:34)
  at async exportPagesPage (../packages/next/dist/export/routes/pages.js:123:17)
  at async exportPageImpl (../packages/next/dist/export/worker.js:202:16)
  at async Span.traceAsyncFn (../packages/next/dist/trace/trace.js:157:20)·
  > Build error occurred
  Error: Export encountered an error on /dog, exiting the build.
  at exportPageWithRetry (../packages/next/dist/export/worker.js:291:31)
      at async Promise.all (index 5)
  at async Object.exportPages (../packages/next/dist/export/worker.js:315:31) {
    type: 'ExportPageError',
    code: 'NEXT_EXPORT_PAGE_ERROR'
  }
  "
  at Object.toMatch (integration/amp-export-validation/test/index.test.js:28:29)

Read more about building and testing Next.js in contributing.md.

pnpm test-dev test/development/basic/next-rs-api.test.ts

  • next.rs api > should have working HMR on client-side change on a app page 2
  • next.rs api > should have working HMR on server-side change on a app page 0
  • next.rs api > should have working HMR on server-side change on a app page 1
  • next.rs api > should have working HMR on server-side change on a app page 2
Expand output

● next.rs api › should have working HMR on client-side change on a app page 2

expect(received).toHaveProperty(path, value)

Expected path: "type"

Expected value: "issues"
Received value: "restart"

  504 |             expect(result.done).toBe(false)
  505 |             expect(result.value).toHaveProperty('resource', expect.toBeObject())
> 506 |             expect(result.value).toHaveProperty('type', 'issues')
      |                                  ^
  507 |             expect(result.value).toHaveProperty('issues', expect.toBeEmpty())
  508 |             expect(result.value).toHaveProperty(
  509 |               'diagnostics',

  at toHaveProperty (development/basic/next-rs-api.test.ts:506:34)
      at async Promise.all (index 27)
  at Object.<anonymous> (development/basic/next-rs-api.test.ts:501:9)

● next.rs api › should have working HMR on server-side change on a app page 0

expect(received).toHaveProperty(path, value)

Expected path: "type"

Expected value: "issues"
Received value: "restart"

  504 |             expect(result.done).toBe(false)
  505 |             expect(result.value).toHaveProperty('resource', expect.toBeObject())
> 506 |             expect(result.value).toHaveProperty('type', 'issues')
      |                                  ^
  507 |             expect(result.value).toHaveProperty('issues', expect.toBeEmpty())
  508 |             expect(result.value).toHaveProperty(
  509 |               'diagnostics',

  at toHaveProperty (development/basic/next-rs-api.test.ts:506:34)
      at async Promise.all (index 27)
  at Object.<anonymous> (development/basic/next-rs-api.test.ts:501:9)

● next.rs api › should have working HMR on server-side change on a app page 1

expect(received).toHaveProperty(path, value)

Expected path: "type"

Expected value: "issues"
Received value: "restart"

  504 |             expect(result.done).toBe(false)
  505 |             expect(result.value).toHaveProperty('resource', expect.toBeObject())
> 506 |             expect(result.value).toHaveProperty('type', 'issues')
      |                                  ^
  507 |             expect(result.value).toHaveProperty('issues', expect.toBeEmpty())
  508 |             expect(result.value).toHaveProperty(
  509 |               'diagnostics',

  at toHaveProperty (development/basic/next-rs-api.test.ts:506:34)
      at async Promise.all (index 27)
  at Object.<anonymous> (development/basic/next-rs-api.test.ts:501:9)

● next.rs api › should have working HMR on server-side change on a app page 2

expect(received).toHaveProperty(path, value)

Expected path: "type"

Expected value: "issues"
Received value: "restart"

  504 |             expect(result.done).toBe(false)
  505 |             expect(result.value).toHaveProperty('resource', expect.toBeObject())
> 506 |             expect(result.value).toHaveProperty('type', 'issues')
      |                                  ^
  507 |             expect(result.value).toHaveProperty('issues', expect.toBeEmpty())
  508 |             expect(result.value).toHaveProperty(
  509 |               'diagnostics',

  at toHaveProperty (development/basic/next-rs-api.test.ts:506:34)
      at async Promise.all (index 27)
  at Object.<anonymous> (development/basic/next-rs-api.test.ts:501:9)

Read more about building and testing Next.js in contributing.md.

TURBOPACK=1 pnpm test-dev test/e2e/conflicting-app-page-error/index.test.ts (turbopack)

  • Conflict between app file and pages file > should show error overlay for /another
  • Conflict between app file and pages file > should show error overlay for /
  • Conflict between app file and pages file > should support hmr with conflicts
  • Conflict between app file and pages file > should not show error overlay for non conflict pages under app or pages dir
  • Conflict between app file and pages file > should error again when there is new conflict
Expand output

● Conflict between app file and pages file › should show error overlay for /another

expect(received).toContain(expected) // indexOf

Expected substring: "App Router and Pages Router both match path:"
Received string:    "Failed to compile"

  52 |       await assertHasRedbox(browser)
  53 |       if (process.env.TURBOPACK) {
> 54 |         expect(await getRedboxDescription(browser)).toContain(
     |                                                     ^
  55 |           'App Router and Pages Router both match path:'
  56 |         )
  57 |       }

  at toContain (e2e/conflicting-app-page-error/index.test.ts:54:53)
  at retry (lib/next-test-utils.ts:806:14)
  at containConflictsError (e2e/conflicting-app-page-error/index.test.ts:51:5)
  at Object.<anonymous> (e2e/conflicting-app-page-error/index.test.ts:74:7)

● Conflict between app file and pages file › should show error overlay for /

expect(received).toContain(expected) // indexOf

Expected substring: "App Router and Pages Router both match path:"
Received string:    "Failed to compile"

  52 |       await assertHasRedbox(browser)
  53 |       if (process.env.TURBOPACK) {
> 54 |         expect(await getRedboxDescription(browser)).toContain(
     |                                                     ^
  55 |           'App Router and Pages Router both match path:'
  56 |         )
  57 |       }

  at toContain (e2e/conflicting-app-page-error/index.test.ts:54:53)
  at retry (lib/next-test-utils.ts:806:14)
  at containConflictsError (e2e/conflicting-app-page-error/index.test.ts:51:5)
  at Object.<anonymous> (e2e/conflicting-app-page-error/index.test.ts:83:7)

● Conflict between app file and pages file › should support hmr with conflicts

Expected no Redbox but found one
header: Build Error
Next.js (15.0.0-canary.159) (turbo)

Failed to compile
description: Failed to compile
source: ./
App Router and Pages Router both match path: /
Next.js does not support having both App Router and Pages Router routes matching the same path. Please remove one of the conflicting routes.

   96 |       // Wait for successful recompilation
   97 |       await browser.loadPage(next.url + '/')
>  98 |       await assertNoRedbox(browser)
      |       ^
   99 |       expect(await browser.elementByCss('p').text()).toContain('index - app')
  100 |
  101 |       await browser.loadPage(next.url + '/another')

  at Object.<anonymous> (e2e/conflicting-app-page-error/index.test.ts:98:7)

● Conflict between app file and pages file › should not show error overlay for non conflict pages under app or pages dir

Expected no Redbox but found one
header: Build Error
Next.js (15.0.0-canary.159) (turbo)

Failed to compile
description: Failed to compile
source: ./
App Router and Pages Router both match path: /
Next.js does not support having both App Router and Pages Router routes matching the same path. Please remove one of the conflicting routes.

  105 |     it('should not show error overlay for non conflict pages under app or pages dir', async () => {
  106 |       const browser = await next.browser('/non-conflict')
> 107 |       await assertNoRedbox(browser)
      |       ^
  108 |       expect(await getRedboxHeader(browser)).toBeUndefined()
  109 |       expect(await browser.elementByCss('p').text()).toBe('non-conflict app')
  110 |

  at Object.<anonymous> (e2e/conflicting-app-page-error/index.test.ts:107:7)

● Conflict between app file and pages file › should error again when there is new conflict

Expected no Redbox but found one
header: Build Error
Next.js (15.0.0-canary.159) (turbo)

Failed to compile
description: Failed to compile
source: ./
App Router and Pages Router both match path: /
Next.js does not support having both App Router and Pages Router routes matching the same path. Please remove one of the conflicting routes.

  117 |     it('should error again when there is new conflict', async () => {
  118 |       const browser = await next.browser('/')
> 119 |       await assertNoRedbox(browser)
      |       ^
  120 |
  121 |       // Re-trigger the conflicted errors
  122 |       await next.renameFile('pages/index2.js', 'pages/index.js')

  at Object.<anonymous> (e2e/conflicting-app-page-error/index.test.ts:119:7)

Read more about building and testing Next.js in contributing.md.

@ijjk
Copy link
Member

ijjk commented Sep 19, 2024 •
edited
Loading

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js sokra/vc-operation Change
buildDuration 18.4s 15.5s N/A
buildDurationCached 8.5s 7.2s N/A
nodeModulesSize 359 MB 359 MB ✓
nextStartRea..uration (ms) 480ms 436ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sokra/vc-operation Change
5464-HASH.js gzip 5.25 kB 5.26 kB N/A
7961.HASH.js gzip 168 B 168 B ✓
882-HASH.js gzip 42.5 kB 42.6 kB N/A
f700a635-HASH.js gzip 52.8 kB 52.8 kB N/A
framework-HASH.js gzip 57.6 kB 57.6 kB ✓
main-app-HASH.js gzip 226 B 221 B N/A
main-HASH.js gzip 32.6 kB 32.6 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 57.7 kB 57.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sokra/vc-operation Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 39.4 kB 39.4 kB ✓
Client Pages
vercel/next.js canary vercel/next.js sokra/vc-operation Change
_app-HASH.js gzip 193 B 194 B N/A
_error-HASH.js gzip 192 B 191 B N/A
amp-HASH.js gzip 509 B 511 B N/A
css-HASH.js gzip 341 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB ✓
edge-ssr-HASH.js gzip 264 B 266 B N/A
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 391 B 389 B N/A
image-HASH.js gzip 4.39 kB 4.4 kB N/A
index-HASH.js gzip 268 B 267 B N/A
link-HASH.js gzip 2.81 kB 2.81 kB N/A
routerDirect..HASH.js gzip 327 B 328 B N/A
script-HASH.js gzip 396 B 393 B N/A
withRouter-HASH.js gzip 322 B 323 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 1.95 kB 1.95 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js sokra/vc-operation Change
_buildManifest.js gzip 747 B 751 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js sokra/vc-operation Change
index.html gzip 522 B 524 B N/A
link.html gzip 536 B 538 B N/A
withRouter.html gzip 518 B 520 B N/A
Overall change 0 B 0 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sokra/vc-operation Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 179 kB 179 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js sokra/vc-operation Change
middleware-b..fest.js gzip 670 B 667 B N/A
middleware-r..fest.js gzip 156 B 156 B ✓
middleware.js gzip 29.8 kB 29.8 kB N/A
edge-runtime..pack.js gzip 844 B 844 B ✓
Overall change 1 kB 1 kB ✓
Next Runtimes
vercel/next.js canary vercel/next.js sokra/vc-operation Change
973-experime...dev.js gzip 322 B 322 B ✓
973.runtime.dev.js gzip 314 B 314 B ✓
app-page-exp...dev.js gzip 318 kB 318 kB ✓
app-page-exp..prod.js gzip 125 kB 125 kB ✓
app-page-tur..prod.js gzip 139 kB 139 kB ✓
app-page-tur..prod.js gzip 134 kB 134 kB ✓
app-page.run...dev.js gzip 308 kB 308 kB ✓
app-page.run..prod.js gzip 121 kB 121 kB ✓
app-route-ex...dev.js gzip 32.1 kB 32.1 kB ✓
app-route-ex..prod.js gzip 21.7 kB 21.7 kB ✓
app-route-tu..prod.js gzip 21.7 kB 21.7 kB ✓
app-route-tu..prod.js gzip 21.5 kB 21.5 kB ✓
app-route.ru...dev.js gzip 33.7 kB 33.7 kB ✓
app-route.ru..prod.js gzip 21.5 kB 21.5 kB ✓
pages-api-tu..prod.js gzip 9.62 kB 9.62 kB ✓
pages-api.ru...dev.js gzip 11.5 kB 11.5 kB ✓
pages-api.ru..prod.js gzip 9.61 kB 9.61 kB ✓
pages-turbo...prod.js gzip 20.8 kB 20.8 kB ✓
pages.runtim...dev.js gzip 26.4 kB 26.4 kB ✓
pages.runtim..prod.js gzip 20.8 kB 20.8 kB ✓
server.runti..prod.js gzip 57.8 kB 57.8 kB ✓
Overall change 1.45 MB 1.45 MB ✓
build cache
vercel/next.js canary vercel/next.js sokra/vc-operation Change
0.pack gzip 1.66 MB 1.66 MB N/A
index.pack gzip 132 kB 131 kB N/A
Overall change 0 B 0 B ✓
Diff details
Diff for page.js 
@@ -15,7 +15,7 @@
       /***/
     },
 
-    /***/ 7286: /***/ (
+    /***/ 392: /***/ (
       __unused_webpack_module,
       __webpack_exports__,
       __webpack_require__
@@ -30,7 +30,7 @@
         default: () => /* binding */ nHandler,
       });
 
-      // NAMESPACE OBJECT: ./node_modules/.pnpm/next@file+..+main-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-5dcb0097-20240918_re_4tprv27tnzmhlzw6zr76ump37a/node_modules/next/dist/build/webpack/loaders/next-app-loader.js?name=app%2Fapp-edge-ssr%2Fpage&page=%2Fapp-edge-ssr%2Fpage&pagePath=private-next-app-dir%2Fapp-edge-ssr%2Fpage.js&appDir=%2Ftmp%2Fnext-statsbYuR5S%2Fstats-app%2Fapp&appPaths=%2Fapp-edge-ssr%2Fpage&pageExtensions=tsx&pageExtensions=ts&pageExtensions=jsx&pageExtensions=js&basePath=&assetPrefix=&nextConfigOutput=&flyingShuttle=false&preferredRegion=&middlewareConfig=e30%3D!./app/app-edge-ssr/page.js?__next_edge_ssr_entry__
+      // NAMESPACE OBJECT: ./node_modules/.pnpm/next@file+..+diff-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-5dcb0097-20240918_re_o75yynpdjzlx53graik6vcrqwq/node_modules/next/dist/build/webpack/loaders/next-app-loader.js?name=app%2Fapp-edge-ssr%2Fpage&page=%2Fapp-edge-ssr%2Fpage&pagePath=private-next-app-dir%2Fapp-edge-ssr%2Fpage.js&appDir=%2Ftmp%2Fnext-statsbYuR5S%2Fstats-app%2Fapp&appPaths=%2Fapp-edge-ssr%2Fpage&pageExtensions=tsx&pageExtensions=ts&pageExtensions=jsx&pageExtensions=js&basePath=&assetPrefix=&nextConfigOutput=&flyingShuttle=false&preferredRegion=&middlewareConfig=e30%3D!./app/app-edge-ssr/page.js?__next_edge_ssr_entry__
       var page_next_edge_ssr_entry_namespaceObject = {};
       __webpack_require__.r(page_next_edge_ssr_entry_namespaceObject);
       __webpack_require__.d(page_next_edge_ssr_entry_namespaceObject, {
@@ -69,35 +69,35 @@
         tree: () => tree,
       });
 
-      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+main-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-5dcb0097-20240918_re_4tprv27tnzmhlzw6zr76ump37a/node_modules/next/dist/esm/server/web/globals.js
-      var globals = __webpack_require__(3638);
-      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+main-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-5dcb0097-20240918_re_4tprv27tnzmhlzw6zr76ump37a/node_modules/next/dist/esm/server/web/adapter.js + 3 modules
-      var adapter = __webpack_require__(9798);
-      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+main-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-5dcb0097-20240918_re_4tprv27tnzmhlzw6zr76ump37a/node_modules/next/dist/esm/build/webpack/loaders/next-edge-ssr-loader/render.js + 85 modules
-      var render = __webpack_require__(4497);
-      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+main-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-5dcb0097-20240918_re_4tprv27tnzmhlzw6zr76ump37a/node_modules/next/dist/esm/server/lib/incremental-cache/index.js + 3 modules
-      var incremental_cache = __webpack_require__(3136);
-      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+main-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-5dcb0097-20240918_re_4tprv27tnzmhlzw6zr76ump37a/node_modules/next/dist/esm/server/app-render/app-render.js + 74 modules
-      var app_render = __webpack_require__(3527);
-      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+main-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-5dcb0097-20240918_re_4tprv27tnzmhlzw6zr76ump37a/node_modules/next/dist/esm/server/route-modules/app-page/module.compiled.js
-      var module_compiled = __webpack_require__(3576);
-      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+main-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-5dcb0097-20240918_re_4tprv27tnzmhlzw6zr76ump37a/node_modules/next/dist/esm/server/route-kind.js
-      var route_kind = __webpack_require__(8888);
-      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+main-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-5dcb0097-20240918_re_4tprv27tnzmhlzw6zr76ump37a/node_modules/next/dist/esm/client/components/error-boundary.js
-      var error_boundary = __webpack_require__(2766);
-      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+main-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-5dcb0097-20240918_re_4tprv27tnzmhlzw6zr76ump37a/node_modules/next/dist/esm/server/app-render/entry-base.js + 9 modules
-      var entry_base = __webpack_require__(3037); // CONCATENATED MODULE: ./node_modules/.pnpm/next@file+..+main-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-5dcb0097-20240918_re_4tprv27tnzmhlzw6zr76ump37a/node_modules/next/dist/build/webpack/loaders/next-app-loader.js?name=app%2Fapp-edge-ssr%2Fpage&page=%2Fapp-edge-ssr%2Fpage&pagePath=private-next-app-dir%2Fapp-edge-ssr%2Fpage.js&appDir=%2Ftmp%2Fnext-statsbYuR5S%2Fstats-app%2Fapp&appPaths=%2Fapp-edge-ssr%2Fpage&pageExtensions=tsx&pageExtensions=ts&pageExtensions=jsx&pageExtensions=js&basePath=&assetPrefix=&nextConfigOutput=&flyingShuttle=false&preferredRegion=&middlewareConfig=e30%3D!./app/app-edge-ssr/page.js?__next_edge_ssr_entry__
+      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+diff-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-5dcb0097-20240918_re_o75yynpdjzlx53graik6vcrqwq/node_modules/next/dist/esm/server/web/globals.js
+      var globals = __webpack_require__(837);
+      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+diff-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-5dcb0097-20240918_re_o75yynpdjzlx53graik6vcrqwq/node_modules/next/dist/esm/server/web/adapter.js + 3 modules
+      var adapter = __webpack_require__(8871);
+      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+diff-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-5dcb0097-20240918_re_o75yynpdjzlx53graik6vcrqwq/node_modules/next/dist/esm/build/webpack/loaders/next-edge-ssr-loader/render.js + 85 modules
+      var render = __webpack_require__(260);
+      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+diff-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-5dcb0097-20240918_re_o75yynpdjzlx53graik6vcrqwq/node_modules/next/dist/esm/server/lib/incremental-cache/index.js + 3 modules
+      var incremental_cache = __webpack_require__(7685);
+      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+diff-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-5dcb0097-20240918_re_o75yynpdjzlx53graik6vcrqwq/node_modules/next/dist/esm/server/app-render/app-render.js + 74 modules
+      var app_render = __webpack_require__(883);
+      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+diff-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-5dcb0097-20240918_re_o75yynpdjzlx53graik6vcrqwq/node_modules/next/dist/esm/server/route-modules/app-page/module.compiled.js
+      var module_compiled = __webpack_require__(8858);
+      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+diff-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-5dcb0097-20240918_re_o75yynpdjzlx53graik6vcrqwq/node_modules/next/dist/esm/server/route-kind.js
+      var route_kind = __webpack_require__(1814);
+      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+diff-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-5dcb0097-20240918_re_o75yynpdjzlx53graik6vcrqwq/node_modules/next/dist/esm/client/components/error-boundary.js
+      var error_boundary = __webpack_require__(6953);
+      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+diff-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-5dcb0097-20240918_re_o75yynpdjzlx53graik6vcrqwq/node_modules/next/dist/esm/server/app-render/entry-base.js + 9 modules
+      var entry_base = __webpack_require__(525); // CONCATENATED MODULE: ./node_modules/.pnpm/next@file+..+diff-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-5dcb0097-20240918_re_o75yynpdjzlx53graik6vcrqwq/node_modules/next/dist/build/webpack/loaders/next-app-loader.js?name=app%2Fapp-edge-ssr%2Fpage&page=%2Fapp-edge-ssr%2Fpage&pagePath=private-next-app-dir%2Fapp-edge-ssr%2Fpage.js&appDir=%2Ftmp%2Fnext-statsbYuR5S%2Fstats-app%2Fapp&appPaths=%2Fapp-edge-ssr%2Fpage&pageExtensions=tsx&pageExtensions=ts&pageExtensions=jsx&pageExtensions=js&basePath=&assetPrefix=&nextConfigOutput=&flyingShuttle=false&preferredRegion=&middlewareConfig=e30%3D!./app/app-edge-ssr/page.js?__next_edge_ssr_entry__
       const component0 = () =>
         Promise.resolve(/* import() eager */).then(
-          __webpack_require__.bind(__webpack_require__, 8526)
+          __webpack_require__.bind(__webpack_require__, 8959)
         );
       const component1 = () =>
         Promise.resolve(/* import() eager */).then(
-          __webpack_require__.bind(__webpack_require__, 3356)
+          __webpack_require__.bind(__webpack_require__, 1784)
         );
       const page2 = () =>
         Promise.resolve(/* import() eager */).then(
-          __webpack_require__.bind(__webpack_require__, 1531)
+          __webpack_require__.bind(__webpack_require__, 2564)
         );
 
       // We inject the tree and pages here so that we can use them in the route
@@ -163,12 +163,12 @@
       });
 
       //# sourceMappingURL=app-page.js.map
-      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+main-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-5dcb0097-20240918_re_4tprv27tnzmhlzw6zr76ump37a/node_modules/next/dist/esm/lib/page-types.js
-      var page_types = __webpack_require__(8927);
-      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+main-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-5dcb0097-20240918_re_4tprv27tnzmhlzw6zr76ump37a/node_modules/next/dist/esm/server/app-render/encryption-utils.js
-      var encryption_utils = __webpack_require__(890);
-      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+main-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-5dcb0097-20240918_re_4tprv27tnzmhlzw6zr76ump37a/node_modules/next/dist/esm/server/app-render/action-utils.js
-      var action_utils = __webpack_require__(124); // CONCATENATED MODULE: ./node_modules/.pnpm/next@file+..+main-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-5dcb0097-20240918_re_4tprv27tnzmhlzw6zr76ump37a/node_modules/next/dist/build/webpack/loaders/next-edge-ssr-loader/index.js?{"absolute500Path":"","absoluteAppPath":"next/dist/pages/_app","absoluteDocumentPath":"next/dist/pages/_document","absoluteErrorPath":"next/dist/pages/_error","absolutePagePath":"private-next-app-dir/app-edge-ssr/page.js","dev":false,"isServerComponent":true,"page":"/app-edge-ssr/page","stringifiedConfig":"eyJlbnYiOnt9LCJlc2xpbnQiOnsiaWdub3JlRHVyaW5nQnVpbGRzIjpmYWxzZX0sInR5cGVzY3JpcHQiOnsiaWdub3JlQnVpbGRFcnJvcnMiOmZhbHNlLCJ0c2NvbmZpZ1BhdGgiOiJ0c2NvbmZpZy5qc29uIn0sImRpc3REaXIiOiIubmV4dCIsImNsZWFuRGlzdERpciI6dHJ1ZSwiYXNzZXRQcmVmaXgiOiIiLCJjYWNoZU1heE1lbW9yeVNpemUiOjUyNDI4ODAwLCJjb25maWdPcmlnaW4iOiJuZXh0LmNvbmZpZy5qcyIsInVzZUZpbGVTeXN0ZW1QdWJsaWNSb3V0ZXMiOnRydWUsImdlbmVyYXRlRXRhZ3MiOnRydWUsInBhZ2VFeHRlbnNpb25zIjpbInRzeCIsInRzIiwianN4IiwianMiXSwicG93ZXJlZEJ5SGVhZGVyIjp0cnVlLCJjb21wcmVzcyI6dHJ1ZSwiaW1hZ2VzIjp7ImRldmljZVNpemVzIjpbNjQwLDc1MCw4MjgsMTA4MCwxMjAwLDE5MjAsMjA0OCwzODQwXSwiaW1hZ2VTaXplcyI6WzE2LDMyLDQ4LDY0LDk2LDEyOCwyNTYsMzg0XSwicGF0aCI6Ii9fbmV4dC9pbWFnZSIsImxvYWRlciI6ImRlZmF1bHQiLCJsb2FkZXJGaWxlIjoiIiwiZG9tYWlucyI6W10sImRpc2FibGVTdGF0aWNJbWFnZXMiOmZhbHNlLCJtaW5pbXVtQ2FjaGVUVEwiOjYwLCJmb3JtYXRzIjpbImltYWdlL3dlYnAiXSwiZGFuZ2Vyb3VzbHlBbGxvd1NWRyI6ZmFsc2UsImNvbnRlbnRTZWN1cml0eVBvbGljeSI6InNjcmlwdC1zcmMgJ25vbmUnOyBmcmFtZS1zcmMgJ25vbmUnOyBzYW5kYm94OyIsImNvbnRlbnREaXNwb3NpdGlvblR5cGUiOiJhdHRhY2htZW50IiwicmVtb3RlUGF0dGVybnMiOltdLCJ1bm9wdGltaXplZCI6ZmFsc2V9LCJkZXZJbmRpY2F0b3JzIjp7ImFwcElzclN0YXR1cyI6dHJ1ZSwiYnVpbGRBY3Rpdml0eSI6dHJ1ZSwiYnVpbGRBY3Rpdml0eVBvc2l0aW9uIjoiYm90dG9tLXJpZ2h0In0sIm9uRGVtYW5kRW50cmllcyI6eyJtYXhJbmFjdGl2ZUFnZSI6NjAwMDAsInBhZ2VzQnVmZmVyTGVuZ3RoIjo1fSwiYW1wIjp7ImNhbm9uaWNhbEJhc2UiOiIifSwiYmFzZVBhdGgiOiIiLCJzYXNzT3B0aW9ucyI6e30sInRyYWlsaW5nU2xhc2giOmZhbHNlLCJpMThuIjpudWxsLCJwcm9kdWN0aW9uQnJvd3NlclNvdXJjZU1hcHMiOmZhbHNlLCJleGNsdWRlRGVmYXVsdE1vbWVudExvY2FsZXMiOnRydWUsInNlcnZlclJ1bnRpbWVDb25maWciOnt9LCJwdWJsaWNSdW50aW1lQ29uZmlnIjp7fSwicmVhY3RQcm9kdWN0aW9uUHJvZmlsaW5nIjpmYWxzZSwicmVhY3RTdHJpY3RNb2RlIjpudWxsLCJyZWFjdE1heEhlYWRlcnNMZW5ndGgiOjYwMDAsImh0dHBBZ2VudE9wdGlvbnMiOnsia2VlcEFsaXZlIjp0cnVlfSwibG9nZ2luZyI6e30sInN0YXRpY1BhZ2VHZW5lcmF0aW9uVGltZW91dCI6NjAsIm1vZHVsYXJpemVJbXBvcnRzIjp7IkBtdWkvaWNvbnMtbWF0ZXJpYWwiOnsidHJhbnNmb3JtIjoiQG11aS9pY29ucy1tYXRlcmlhbC97e21lbWJlcn19In0sImxvZGFzaCI6eyJ0cmFuc2Zvcm0iOiJsb2Rhc2gve3ttZW1iZXJ9fSJ9fSwib3V0cHV0RmlsZVRyYWNpbmdSb290IjoiL3RtcC9uZXh0LXN0YXRzYll1UjVTL3N0YXRzLWFwcCIsImV4cGVyaW1lbnRhbCI6eyJtdWx0aVpvbmVEcmFmdE1vZGUiOmZhbHNlLCJhcHBOYXZGYWlsSGFuZGxpbmciOmZhbHNlLCJwcmVyZW5kZXJFYXJseUV4aXQiOnRydWUsInNlcnZlck1pbmlmaWNhdGlvbiI6dHJ1ZSwic2VydmVyU291cmNlTWFwcyI6ZmFsc2UsImxpbmtOb1RvdWNoU3RhcnQiOmZhbHNlLCJjYXNlU2Vuc2l0aXZlUm91dGVzIjpmYWxzZSwicHJlbG9hZEVudHJpZXNPblN0YXJ0Ijp0cnVlLCJjbGllbnRSb3V0ZXJGaWx0ZXIiOnRydWUsImNsaWVudFJvdXRlckZpbHRlclJlZGlyZWN0cyI6ZmFsc2UsImZldGNoQ2FjaGVLZXlQcmVmaXgiOiIiLCJtaWRkbGV3YXJlUHJlZmV0Y2giOiJmbGV4aWJsZSIsIm9wdGltaXN0aWNDbGllbnRDYWNoZSI6dHJ1ZSwibWFudWFsQ2xpZW50QmFzZVBhdGgiOmZhbHNlLCJjcHVzIjoxOSwibWVtb3J5QmFzZWRXb3JrZXJzQ291bnQiOmZhbHNlLCJpc3JGbHVzaFRvRGlzayI6dHJ1ZSwid29ya2VyVGhyZWFkcyI6ZmFsc2UsIm9wdGltaXplQ3NzIjpmYWxzZSwibmV4dFNjcmlwdFdvcmtlcnMiOmZhbHNlLCJzY3JvbGxSZXN0b3JhdGlvbiI6ZmFsc2UsImV4dGVybmFsRGlyIjpmYWxzZSwiZGlzYWJsZU9wdGltaXplZExvYWRpbmciOmZhbHNlLCJnemlwU2l6ZSI6dHJ1ZSwiY3JhQ29tcGF0IjpmYWxzZSwiZXNtRXh0ZXJuYWxzIjp0cnVlLCJmdWxseVNwZWNpZmllZCI6ZmFsc2UsInN3Y1RyYWNlUHJvZmlsaW5nIjpmYWxzZSwiZm9yY2VTd2NUcmFuc2Zvcm1zIjpmYWxzZSwibGFyZ2VQYWdlRGF0YUJ5dGVzIjoxMjgwMDAsInR1cmJvIjp7InJvb3QiOiIvdG1wL25leHQtc3RhdHNiWXVSNVMvc3RhdHMtYXBwIn0sInR5cGVkUm91dGVzIjpmYWxzZSwidHlwZWRFbnYiOmZhbHNlLCJwYXJhbGxlbFNlcnZlckNvbXBpbGVzIjpmYWxzZSwicGFyYWxsZWxTZXJ2ZXJCdWlsZFRyYWNlcyI6ZmFsc2UsInBwciI6ZmFsc2UsInBwckZhbGxiYWNrcyI6ZmFsc2UsIndlYnBhY2tNZW1vcnlPcHRpbWl6YXRpb25zIjpmYWxzZSwib3B0aW1pemVTZXJ2ZXJSZWFjdCI6dHJ1ZSwidXNlRWFybHlJbXBvcnQiOmZhbHNlLCJzdGFsZVRpbWVzIjp7ImR5bmFtaWMiOjAsInN0YXRpYyI6MzAwfSwiYWZ0ZXIiOmZhbHNlLCJzZXJ2ZXJDb21wb25lbnRzSG1yQ2FjaGUiOnRydWUsInN0YXRpY0dlbmVyYXRpb25NYXhDb25jdXJyZW5jeSI6OCwic3RhdGljR2VuZXJhdGlvbk1pblBhZ2VzUGVyV29ya2VyIjoyNSwiZHluYW1pY0lPIjpmYWxzZSwib3B0aW1pemVQYWNrYWdlSW1wb3J0cyI6WyJsdWNpZGUtcmVhY3QiLCJkYXRlLWZucyIsImxvZGFzaC1lcyIsInJhbWRhIiwiYW50ZCIsInJlYWN0LWJvb3RzdHJhcCIsImFob29rcyIsIkBhbnQtZGVzaWduL2ljb25zIiwiQGhlYWRsZXNzdWkvcmVhY3QiLCJAaGVhZGxlc3N1aS1mbG9hdC9yZWFjdCIsIkBoZXJvaWNvbnMvcmVhY3QvMjAvc29saWQiLCJAaGVyb2ljb25zL3JlYWN0LzI0L3NvbGlkIiwiQGhlcm9pY29ucy9yZWFjdC8yNC9vdXRsaW5lIiwiQHZpc3gvdmlzeCIsIkB0cmVtb3IvcmVhY3QiLCJyeGpzIiwiQG11aS9tYXRlcmlhbCIsIkBtdWkvaWNvbnMtbWF0ZXJpYWwiLCJyZWNoYXJ0cyIsInJlYWN0LXVzZSIsImVmZmVjdCIsIkBlZmZlY3Qvc2NoZW1hIiwiQGVmZmVjdC9wbGF0Zm9ybSIsIkBlZmZlY3QvcGxhdGZvcm0tbm9kZSIsIkBlZmZlY3QvcGxhdGZvcm0tYnJvd3NlciIsIkBlZmZlY3QvcGxhdGZvcm0tYnVuIiwiQGVmZmVjdC9zcWwiLCJAZWZmZWN0L3NxbC1tc3NxbCIsIkBlZmZlY3Qvc3FsLW15c3FsMiIsIkBlZmZlY3Qvc3FsLXBnIiwiQGVmZmVjdC9zcWwtc3F1bGl0ZS1ub2RlIiwiQGVmZmVjdC9zcWwtc3F1bGl0ZS1idW4iLCJAZWZmZWN0L3NxbC1zcXVsaXRlLXdhc20iLCJAZWZmZWN0L3NxbC1zcXVsaXRlLXJlYWN0LW5hdGl2ZSIsIkBlZmZlY3QvcnBjIiwiQGVmZmVjdC9ycGMtaHR0cCIsIkBlZmZlY3QvdHlwZWNsYXNzIiwiQGVmZmVjdC9leHBlcmltZW50YWwiLCJAZWZmZWN0L29wZW50ZWxlbWV0cnkiLCJAbWF0ZXJpYWwtdWkvY29yZSIsIkBtYXRlcmlhbC11aS9pY29ucyIsIkB0YWJsZXIvaWNvbnMtcmVhY3QiLCJtdWktY29yZSIsInJlYWN0LWljb25zL2FpIiwicmVhY3QtaWNvbnMvYmkiLCJyZWFjdC1pY29ucy9icyIsInJlYWN0LWljb25zL2NnIiwicmVhY3QtaWNvbnMvY2kiLCJyZWFjdC1pY29ucy9kaSIsInJlYWN0LWljb25zL2ZhIiwicmVhY3QtaWNvbnMvZmE2IiwicmVhY3QtaWNvbnMvZmMiLCJyZWFjdC1pY29ucy9maSIsInJlYWN0LWljb25zL2dpIiwicmVhY3QtaWNvbnMvZ28iLCJyZWFjdC1pY29ucy9nciIsInJlYWN0LWljb25zL2hpIiwicmVhY3QtaWNvbnMvaGkyIiwicmVhY3QtaWNvbnMvaW0iLCJyZWFjdC1pY29ucy9pbyIsInJlYWN0LWljb25zL2lvNSIsInJlYWN0LWljb25zL2xpYSIsInJlYWN0LWljb25zL2xpYiIsInJlYWN0LWljb25zL2x1IiwicmVhY3QtaWNvbnMvbWQiLCJyZWFjdC1pY29ucy9waSIsInJlYWN0LWljb25zL3JpIiwicmVhY3QtaWNvbnMvcngiLCJyZWFjdC1pY29ucy9zaSIsInJlYWN0LWljb25zL3NsIiwicmVhY3QtaWNvbnMvdGIiLCJyZWFjdC1pY29ucy90ZmkiLCJyZWFjdC1pY29ucy90aSIsInJlYWN0LWljb25zL3ZzYyIsInJlYWN0LWljb25zL3dpIl19LCJidW5kbGVQYWdlc1JvdXRlckRlcGVuZGVuY2llcyI6ZmFsc2UsImNvbmZpZ0ZpbGUiOiIvdG1wL25leHQtc3RhdHNiWXVSNVMvc3RhdHMtYXBwL25leHQuY29uZmlnLmpzIiwiY29uZmlnRmlsZU5hbWUiOiJuZXh0LmNvbmZpZy5qcyJ9","pagesType":"app","appDirLoader":"bmV4dC1hcHAtbG9hZGVyP25hbWU9YXBwJTJGYXBwLWVkZ2Utc3NyJTJGcGFnZSZwYWdlPSUyRmFwcC1lZGdlLXNzciUyRnBhZ2UmcGFnZVBhdGg9cHJpdmF0ZS1uZXh0LWFwcC1kaXIlMkZhcHAtZWRnZS1zc3IlMkZwYWdlLmpzJmFwcERpcj0lMkZ0bXAlMkZuZXh0LXN0YXRzYll1UjVTJTJGc3RhdHMtYXBwJTJGYXBwJmFwcFBhdGhzPSUyRmFwcC1lZGdlLXNzciUyRnBhZ2UmcGFnZUV4dGVuc2lvbnM9dHN4JnBhZ2VFeHRlbnNpb25zPXRzJnBhZ2VFeHRlbnNpb25zPWpzeCZwYWdlRXh0ZW5zaW9ucz1qcyZiYXNlUGF0aD0mYXNzZXRQcmVmaXg9Jm5leHRDb25maWdPdXRwdXQ9JmZseWluZ1NodXR0bGU9ZmFsc2UmcHJlZmVycmVkUmVnaW9uPSZtaWRkbGV3YXJlQ29uZmlnPWUzMCUzRCE=","sriEnabled":false,"middlewareConfig":"e30="}!
+      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+diff-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-5dcb0097-20240918_re_o75yynpdjzlx53graik6vcrqwq/node_modules/next/dist/esm/lib/page-types.js
+      var page_types = __webpack_require__(8818);
+      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+diff-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-5dcb0097-20240918_re_o75yynpdjzlx53graik6vcrqwq/node_modules/next/dist/esm/server/app-render/encryption-utils.js
+      var encryption_utils = __webpack_require__(9687);
+      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+diff-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-5dcb0097-20240918_re_o75yynpdjzlx53graik6vcrqwq/node_modules/next/dist/esm/server/app-render/action-utils.js
+      var action_utils = __webpack_require__(1624); // CONCATENATED MODULE: ./node_modules/.pnpm/next@file+..+diff-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-5dcb0097-20240918_re_o75yynpdjzlx53graik6vcrqwq/node_modules/next/dist/build/webpack/loaders/next-edge-ssr-loader/index.js?{"absolute500Path":"","absoluteAppPath":"next/dist/pages/_app","absoluteDocumentPath":"next/dist/pages/_document","absoluteErrorPath":"next/dist/pages/_error","absolutePagePath":"private-next-app-dir/app-edge-ssr/page.js","dev":false,"isServerComponent":true,"page":"/app-edge-ssr/page","stringifiedConfig":"eyJlbnYiOnt9LCJlc2xpbnQiOnsiaWdub3JlRHVyaW5nQnVpbGRzIjpmYWxzZX0sInR5cGVzY3JpcHQiOnsiaWdub3JlQnVpbGRFcnJvcnMiOmZhbHNlLCJ0c2NvbmZpZ1BhdGgiOiJ0c2NvbmZpZy5qc29uIn0sImRpc3REaXIiOiIubmV4dCIsImNsZWFuRGlzdERpciI6dHJ1ZSwiYXNzZXRQcmVmaXgiOiIiLCJjYWNoZU1heE1lbW9yeVNpemUiOjUyNDI4ODAwLCJjb25maWdPcmlnaW4iOiJuZXh0LmNvbmZpZy5qcyIsInVzZUZpbGVTeXN0ZW1QdWJsaWNSb3V0ZXMiOnRydWUsImdlbmVyYXRlRXRhZ3MiOnRydWUsInBhZ2VFeHRlbnNpb25zIjpbInRzeCIsInRzIiwianN4IiwianMiXSwicG93ZXJlZEJ5SGVhZGVyIjp0cnVlLCJjb21wcmVzcyI6dHJ1ZSwiaW1hZ2VzIjp7ImRldmljZVNpemVzIjpbNjQwLDc1MCw4MjgsMTA4MCwxMjAwLDE5MjAsMjA0OCwzODQwXSwiaW1hZ2VTaXplcyI6WzE2LDMyLDQ4LDY0LDk2LDEyOCwyNTYsMzg0XSwicGF0aCI6Ii9fbmV4dC9pbWFnZSIsImxvYWRlciI6ImRlZmF1bHQiLCJsb2FkZXJGaWxlIjoiIiwiZG9tYWlucyI6W10sImRpc2FibGVTdGF0aWNJbWFnZXMiOmZhbHNlLCJtaW5pbXVtQ2FjaGVUVEwiOjYwLCJmb3JtYXRzIjpbImltYWdlL3dlYnAiXSwiZGFuZ2Vyb3VzbHlBbGxvd1NWRyI6ZmFsc2UsImNvbnRlbnRTZWN1cml0eVBvbGljeSI6InNjcmlwdC1zcmMgJ25vbmUnOyBmcmFtZS1zcmMgJ25vbmUnOyBzYW5kYm94OyIsImNvbnRlbnREaXNwb3NpdGlvblR5cGUiOiJhdHRhY2htZW50IiwicmVtb3RlUGF0dGVybnMiOltdLCJ1bm9wdGltaXplZCI6ZmFsc2V9LCJkZXZJbmRpY2F0b3JzIjp7ImFwcElzclN0YXR1cyI6dHJ1ZSwiYnVpbGRBY3Rpdml0eSI6dHJ1ZSwiYnVpbGRBY3Rpdml0eVBvc2l0aW9uIjoiYm90dG9tLXJpZ2h0In0sIm9uRGVtYW5kRW50cmllcyI6eyJtYXhJbmFjdGl2ZUFnZSI6NjAwMDAsInBhZ2VzQnVmZmVyTGVuZ3RoIjo1fSwiYW1wIjp7ImNhbm9uaWNhbEJhc2UiOiIifSwiYmFzZVBhdGgiOiIiLCJzYXNzT3B0aW9ucyI6e30sInRyYWlsaW5nU2xhc2giOmZhbHNlLCJpMThuIjpudWxsLCJwcm9kdWN0aW9uQnJvd3NlclNvdXJjZU1hcHMiOmZhbHNlLCJleGNsdWRlRGVmYXVsdE1vbWVudExvY2FsZXMiOnRydWUsInNlcnZlclJ1bnRpbWVDb25maWciOnt9LCJwdWJsaWNSdW50aW1lQ29uZmlnIjp7fSwicmVhY3RQcm9kdWN0aW9uUHJvZmlsaW5nIjpmYWxzZSwicmVhY3RTdHJpY3RNb2RlIjpudWxsLCJyZWFjdE1heEhlYWRlcnNMZW5ndGgiOjYwMDAsImh0dHBBZ2VudE9wdGlvbnMiOnsia2VlcEFsaXZlIjp0cnVlfSwibG9nZ2luZyI6e30sInN0YXRpY1BhZ2VHZW5lcmF0aW9uVGltZW91dCI6NjAsIm1vZHVsYXJpemVJbXBvcnRzIjp7IkBtdWkvaWNvbnMtbWF0ZXJpYWwiOnsidHJhbnNmb3JtIjoiQG11aS9pY29ucy1tYXRlcmlhbC97e21lbWJlcn19In0sImxvZGFzaCI6eyJ0cmFuc2Zvcm0iOiJsb2Rhc2gve3ttZW1iZXJ9fSJ9fSwib3V0cHV0RmlsZVRyYWNpbmdSb290IjoiL3RtcC9uZXh0LXN0YXRzYll1UjVTL3N0YXRzLWFwcCIsImV4cGVyaW1lbnRhbCI6eyJtdWx0aVpvbmVEcmFmdE1vZGUiOmZhbHNlLCJhcHBOYXZGYWlsSGFuZGxpbmciOmZhbHNlLCJwcmVyZW5kZXJFYXJseUV4aXQiOnRydWUsInNlcnZlck1pbmlmaWNhdGlvbiI6dHJ1ZSwic2VydmVyU291cmNlTWFwcyI6ZmFsc2UsImxpbmtOb1RvdWNoU3RhcnQiOmZhbHNlLCJjYXNlU2Vuc2l0aXZlUm91dGVzIjpmYWxzZSwicHJlbG9hZEVudHJpZXNPblN0YXJ0Ijp0cnVlLCJjbGllbnRSb3V0ZXJGaWx0ZXIiOnRydWUsImNsaWVudFJvdXRlckZpbHRlclJlZGlyZWN0cyI6ZmFsc2UsImZldGNoQ2FjaGVLZXlQcmVmaXgiOiIiLCJtaWRkbGV3YXJlUHJlZmV0Y2giOiJmbGV4aWJsZSIsIm9wdGltaXN0aWNDbGllbnRDYWNoZSI6dHJ1ZSwibWFudWFsQ2xpZW50QmFzZVBhdGgiOmZhbHNlLCJjcHVzIjoxOSwibWVtb3J5QmFzZWRXb3JrZXJzQ291bnQiOmZhbHNlLCJpc3JGbHVzaFRvRGlzayI6dHJ1ZSwid29ya2VyVGhyZWFkcyI6ZmFsc2UsIm9wdGltaXplQ3NzIjpmYWxzZSwibmV4dFNjcmlwdFdvcmtlcnMiOmZhbHNlLCJzY3JvbGxSZXN0b3JhdGlvbiI6ZmFsc2UsImV4dGVybmFsRGlyIjpmYWxzZSwiZGlzYWJsZU9wdGltaXplZExvYWRpbmciOmZhbHNlLCJnemlwU2l6ZSI6dHJ1ZSwiY3JhQ29tcGF0IjpmYWxzZSwiZXNtRXh0ZXJuYWxzIjp0cnVlLCJmdWxseVNwZWNpZmllZCI6ZmFsc2UsInN3Y1RyYWNlUHJvZmlsaW5nIjpmYWxzZSwiZm9yY2VTd2NUcmFuc2Zvcm1zIjpmYWxzZSwibGFyZ2VQYWdlRGF0YUJ5dGVzIjoxMjgwMDAsInR1cmJvIjp7InJvb3QiOiIvdG1wL25leHQtc3RhdHNiWXVSNVMvc3RhdHMtYXBwIn0sInR5cGVkUm91dGVzIjpmYWxzZSwidHlwZWRFbnYiOmZhbHNlLCJwYXJhbGxlbFNlcnZlckNvbXBpbGVzIjpmYWxzZSwicGFyYWxsZWxTZXJ2ZXJCdWlsZFRyYWNlcyI6ZmFsc2UsInBwciI6ZmFsc2UsInBwckZhbGxiYWNrcyI6ZmFsc2UsIndlYnBhY2tNZW1vcnlPcHRpbWl6YXRpb25zIjpmYWxzZSwib3B0aW1pemVTZXJ2ZXJSZWFjdCI6dHJ1ZSwidXNlRWFybHlJbXBvcnQiOmZhbHNlLCJzdGFsZVRpbWVzIjp7ImR5bmFtaWMiOjAsInN0YXRpYyI6MzAwfSwiYWZ0ZXIiOmZhbHNlLCJzZXJ2ZXJDb21wb25lbnRzSG1yQ2FjaGUiOnRydWUsInN0YXRpY0dlbmVyYXRpb25NYXhDb25jdXJyZW5jeSI6OCwic3RhdGljR2VuZXJhdGlvbk1pblBhZ2VzUGVyV29ya2VyIjoyNSwiZHluYW1pY0lPIjpmYWxzZSwib3B0aW1pemVQYWNrYWdlSW1wb3J0cyI6WyJsdWNpZGUtcmVhY3QiLCJkYXRlLWZucyIsImxvZGFzaC1lcyIsInJhbWRhIiwiYW50ZCIsInJlYWN0LWJvb3RzdHJhcCIsImFob29rcyIsIkBhbnQtZGVzaWduL2ljb25zIiwiQGhlYWRsZXNzdWkvcmVhY3QiLCJAaGVhZGxlc3N1aS1mbG9hdC9yZWFjdCIsIkBoZXJvaWNvbnMvcmVhY3QvMjAvc29saWQiLCJAaGVyb2ljb25zL3JlYWN0LzI0L3NvbGlkIiwiQGhlcm9pY29ucy9yZWFjdC8yNC9vdXRsaW5lIiwiQHZpc3gvdmlzeCIsIkB0cmVtb3IvcmVhY3QiLCJyeGpzIiwiQG11aS9tYXRlcmlhbCIsIkBtdWkvaWNvbnMtbWF0ZXJpYWwiLCJyZWNoYXJ0cyIsInJlYWN0LXVzZSIsImVmZmVjdCIsIkBlZmZlY3Qvc2NoZW1hIiwiQGVmZmVjdC9wbGF0Zm9ybSIsIkBlZmZlY3QvcGxhdGZvcm0tbm9kZSIsIkBlZmZlY3QvcGxhdGZvcm0tYnJvd3NlciIsIkBlZmZlY3QvcGxhdGZvcm0tYnVuIiwiQGVmZmVjdC9zcWwiLCJAZWZmZWN0L3NxbC1tc3NxbCIsIkBlZmZlY3Qvc3FsLW15c3FsMiIsIkBlZmZlY3Qvc3FsLXBnIiwiQGVmZmVjdC9zcWwtc3F1bGl0ZS1ub2RlIiwiQGVmZmVjdC9zcWwtc3F1bGl0ZS1idW4iLCJAZWZmZWN0L3NxbC1zcXVsaXRlLXdhc20iLCJAZWZmZWN0L3NxbC1zcXVsaXRlLXJlYWN0LW5hdGl2ZSIsIkBlZmZlY3QvcnBjIiwiQGVmZmVjdC9ycGMtaHR0cCIsIkBlZmZlY3QvdHlwZWNsYXNzIiwiQGVmZmVjdC9leHBlcmltZW50YWwiLCJAZWZmZWN0L29wZW50ZWxlbWV0cnkiLCJAbWF0ZXJpYWwtdWkvY29yZSIsIkBtYXRlcmlhbC11aS9pY29ucyIsIkB0YWJsZXIvaWNvbnMtcmVhY3QiLCJtdWktY29yZSIsInJlYWN0LWljb25zL2FpIiwicmVhY3QtaWNvbnMvYmkiLCJyZWFjdC1pY29ucy9icyIsInJlYWN0LWljb25zL2NnIiwicmVhY3QtaWNvbnMvY2kiLCJyZWFjdC1pY29ucy9kaSIsInJlYWN0LWljb25zL2ZhIiwicmVhY3QtaWNvbnMvZmE2IiwicmVhY3QtaWNvbnMvZmMiLCJyZWFjdC1pY29ucy9maSIsInJlYWN0LWljb25zL2dpIiwicmVhY3QtaWNvbnMvZ28iLCJyZWFjdC1pY29ucy9nciIsInJlYWN0LWljb25zL2hpIiwicmVhY3QtaWNvbnMvaGkyIiwicmVhY3QtaWNvbnMvaW0iLCJyZWFjdC1pY29ucy9pbyIsInJlYWN0LWljb25zL2lvNSIsInJlYWN0LWljb25zL2xpYSIsInJlYWN0LWljb25zL2xpYiIsInJlYWN0LWljb25zL2x1IiwicmVhY3QtaWNvbnMvbWQiLCJyZWFjdC1pY29ucy9waSIsInJlYWN0LWljb25zL3JpIiwicmVhY3QtaWNvbnMvcngiLCJyZWFjdC1pY29ucy9zaSIsInJlYWN0LWljb25zL3NsIiwicmVhY3QtaWNvbnMvdGIiLCJyZWFjdC1pY29ucy90ZmkiLCJyZWFjdC1pY29ucy90aSIsInJlYWN0LWljb25zL3ZzYyIsInJlYWN0LWljb25zL3dpIl19LCJidW5kbGVQYWdlc1JvdXRlckRlcGVuZGVuY2llcyI6ZmFsc2UsImNvbmZpZ0ZpbGUiOiIvdG1wL25leHQtc3RhdHNiWXVSNVMvc3RhdHMtYXBwL25leHQuY29uZmlnLmpzIiwiY29uZmlnRmlsZU5hbWUiOiJuZXh0LmNvbmZpZy5qcyJ9","pagesType":"app","appDirLoader":"bmV4dC1hcHAtbG9hZGVyP25hbWU9YXBwJTJGYXBwLWVkZ2Utc3NyJTJGcGFnZSZwYWdlPSUyRmFwcC1lZGdlLXNzciUyRnBhZ2UmcGFnZVBhdGg9cHJpdmF0ZS1uZXh0LWFwcC1kaXIlMkZhcHAtZWRnZS1zc3IlMkZwYWdlLmpzJmFwcERpcj0lMkZ0bXAlMkZuZXh0LXN0YXRzYll1UjVTJTJGc3RhdHMtYXBwJTJGYXBwJmFwcFBhdGhzPSUyRmFwcC1lZGdlLXNzciUyRnBhZ2UmcGFnZUV4dGVuc2lvbnM9dHN4JnBhZ2VFeHRlbnNpb25zPXRzJnBhZ2VFeHRlbnNpb25zPWpzeCZwYWdlRXh0ZW5zaW9ucz1qcyZiYXNlUGF0aD0mYXNzZXRQcmVmaXg9Jm5leHRDb25maWdPdXRwdXQ9JmZseWluZ1NodXR0bGU9ZmFsc2UmcHJlZmVycmVkUmVnaW9uPSZtaWRkbGV3YXJlQ29uZmlnPWUzMCUzRCE=","sriEnabled":false,"middlewareConfig":"e30="}!
       var _self___RSC_MANIFEST;
 
       const incrementalCacheHandler = null;
@@ -432,50 +432,50 @@
       /***/
     },
 
-    /***/ 4012: /***/ (
+    /***/ 1910: /***/ (
       __unused_webpack_module,
       __unused_webpack_exports,
       __webpack_require__
     ) => {
       Promise.resolve(/* import() eager */).then(
-        __webpack_require__.bind(__webpack_require__, 5907)
+        __webpack_require__.bind(__webpack_require__, 8510)
       );
       Promise.resolve(/* import() eager */).then(
-        __webpack_require__.bind(__webpack_require__, 8674)
+        __webpack_require__.bind(__webpack_require__, 6644)
       );
       Promise.resolve(/* import() eager */).then(
-        __webpack_require__.bind(__webpack_require__, 5903)
+        __webpack_require__.bind(__webpack_require__, 4779)
       );
       Promise.resolve(/* import() eager */).then(
-        __webpack_require__.bind(__webpack_require__, 7959)
+        __webpack_require__.bind(__webpack_require__, 1732)
       );
       Promise.resolve(/* import() eager */).then(
-        __webpack_require__.bind(__webpack_require__, 4811)
+        __webpack_require__.bind(__webpack_require__, 4161)
       );
       Promise.resolve(/* import() eager */).then(
-        __webpack_require__.bind(__webpack_require__, 4171)
+        __webpack_require__.bind(__webpack_require__, 6727)
       );
       Promise.resolve(/* import() eager */).then(
-        __webpack_require__.bind(__webpack_require__, 8074)
+        __webpack_require__.bind(__webpack_require__, 2763)
       );
       Promise.resolve(/* import() eager */).then(
-        __webpack_require__.bind(__webpack_require__, 4614)
+        __webpack_require__.bind(__webpack_require__, 1666)
       );
       Promise.resolve(/* import() eager */).then(
-        __webpack_require__.bind(__webpack_require__, 9658)
+        __webpack_require__.bind(__webpack_require__, 2221)
       );
       Promise.resolve(/* import() eager */).then(
-        __webpack_require__.bind(__webpack_require__, 4863)
+        __webpack_require__.bind(__webpack_require__, 7310)
       );
 
       /***/
     },
 
-    /***/ 7716: /***/ () => {
+    /***/ 2980: /***/ () => {
       /***/
     },
 
-    /***/ 1531: /***/ (
+    /***/ 2564: /***/ (
       __unused_webpack_module,
       __webpack_exports__,
       __webpack_require__
@@ -495,7 +495,7 @@
       /***/
     },
 
-    /***/ 8526: /***/ (
+    /***/ 8959: /***/ (
       __unused_webpack_module,
       __webpack_exports__,
       __webpack_require__
@@ -507,7 +507,7 @@
         /* harmony export */
       });
       /* harmony import */ var react_jsx_runtime__WEBPACK_IMPORTED_MODULE_0__ =
-        __webpack_require__(9166);
+        __webpack_require__(9420);
 
       function RootLayout({ children }) {
         return /*#__PURE__*/ (0,
@@ -526,7 +526,7 @@
     // webpackRuntimeModules
     /******/ var __webpack_exec__ = (moduleId) =>
       __webpack_require__((__webpack_require__.s = moduleId));
-    /******/ __webpack_require__.O(0, [170, 188], () => __webpack_exec__(7286));
+    /******/ __webpack_require__.O(0, [460, 837], () => __webpack_exec__(392));
     /******/ var __webpack_exports__ = __webpack_require__.O();
     /******/ (_ENTRIES = typeof _ENTRIES === "undefined" ? {} : _ENTRIES)[
       "middleware_app/app-edge-ssr/page"
Diff for middleware.js

Diff too large to display

Diff for edge-ssr.js

Diff too large to display

Diff for image-HASH.js 
@@ -1,7 +1,7 @@
 (self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
   [8358],
   {
-    /***/ 2463: /***/ (
+    /***/ 3353: /***/ (
       __unused_webpack_module,
       __unused_webpack_exports,
       __webpack_require__
@@ -9,7 +9,7 @@
       (window.__NEXT_P = window.__NEXT_P || []).push([
         "/image",
         function () {
-          return __webpack_require__(6108);
+          return __webpack_require__(7089);
         },
       ]);
       if (false) {
@@ -18,7 +18,7 @@
       /***/
     },
 
-    /***/ 9846: /***/ (module, exports, __webpack_require__) => {
+    /***/ 1214: /***/ (module, exports, __webpack_require__) => {
       "use strict";
       /* __next_internal_client_entry_do_not_use__  cjs */
       Object.defineProperty(exports, "__esModule", {
@@ -40,17 +40,17 @@
         __webpack_require__(5913)
       );
       const _head = /*#__PURE__*/ _interop_require_default._(
-        __webpack_require__(2268)
+        __webpack_require__(1142)
       );
-      const _getimgprops = __webpack_require__(4265);
-      const _imageconfig = __webpack_require__(6191);
-      const _imageconfigcontextsharedruntime = __webpack_require__(3060);
-      const _warnonce = __webpack_require__(7709);
-      const _routercontextsharedruntime = __webpack_require__(8256);
+      const _getimgprops = __webpack_require__(7566);
+      const _imageconfig = __webpack_require__(6702);
+      const _imageconfigcontextsharedruntime = __webpack_require__(5716);
+      const _warnonce = __webpack_require__(1683);
+      const _routercontextsharedruntime = __webpack_require__(7211);
       const _imageloader = /*#__PURE__*/ _interop_require_default._(
-        __webpack_require__(2583)
+        __webpack_require__(732)
       );
-      const _usemergedref = __webpack_require__(7199);
+      const _usemergedref = __webpack_require__(3345);
       // This is replaced by webpack define plugin
       const configEnv = {
         deviceSizes: [640, 750, 828, 1080, 1200, 1920, 2048, 3840],
@@ -371,7 +371,7 @@
       /***/
     },
 
-    /***/ 7199: /***/ (module, exports, __webpack_require__) => {
+    /***/ 3345: /***/ (module, exports, __webpack_require__) => {
       "use strict";
 
       Object.defineProperty(exports, "__esModule", {
@@ -440,7 +440,7 @@
       /***/
     },
 
-    /***/ 4265: /***/ (
+    /***/ 7566: /***/ (
       __unused_webpack_module,
       exports,
       __webpack_require__
@@ -456,9 +456,9 @@
           return getImgProps;
         },
       });
-      const _warnonce = __webpack_require__(7709);
-      const _imageblursvg = __webpack_require__(676);
-      const _imageconfig = __webpack_require__(6191);
+      const _warnonce = __webpack_require__(1683);
+      const _imageblursvg = __webpack_require__(9223);
+      const _imageconfig = __webpack_require__(6702);
       const VALID_LOADING_VALUES =
         /* unused pure expression or super */ null && [
           "lazy",
@@ -830,7 +830,7 @@
       /***/
     },
 
-    /***/ 676: /***/ (__unused_webpack_module, exports) => {
+    /***/ 9223: /***/ (__unused_webpack_module, exports) => {
       "use strict";
       /**
        * A shared function, used on both client and server, to generate a SVG blur placeholder.
@@ -885,7 +885,7 @@
       /***/
     },
 
-    /***/ 1212: /***/ (
+    /***/ 9894: /***/ (
       __unused_webpack_module,
       exports,
       __webpack_require__
@@ -912,10 +912,10 @@
         },
       });
       const _interop_require_default = __webpack_require__(9608);
-      const _getimgprops = __webpack_require__(4265);
-      const _imagecomponent = __webpack_require__(9846);
+      const _getimgprops = __webpack_require__(7566);
+      const _imagecomponent = __webpack_require__(1214);
       const _imageloader = /*#__PURE__*/ _interop_require_default._(
-        __webpack_require__(2583)
+        __webpack_require__(732)
       );
       function getImageProps(imgProps) {
         const { props } = (0, _getimgprops.getImgProps)(imgProps, {
@@ -947,7 +947,7 @@
       /***/
     },
 
-    /***/ 2583: /***/ (__unused_webpack_module, exports) => {
+    /***/ 732: /***/ (__unused_webpack_module, exports) => {
       "use strict";
 
       Object.defineProperty(exports, "__esModule", {
@@ -982,7 +982,7 @@
       /***/
     },
 
-    /***/ 6108: /***/ (
+    /***/ 7089: /***/ (
       __unused_webpack_module,
       __webpack_exports__,
       __webpack_require__
@@ -999,8 +999,8 @@
 
       // EXTERNAL MODULE: ./node_modules/.pnpm/react@19.0.0-rc-5dcb0097-20240918/node_modules/react/jsx-runtime.js
       var jsx_runtime = __webpack_require__(193);
-      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+main-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-5dcb0097-20240918_re_4tprv27tnzmhlzw6zr76ump37a/node_modules/next/image.js
-      var next_image = __webpack_require__(8301);
+      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+diff-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-5dcb0097-20240918_re_o75yynpdjzlx53graik6vcrqwq/node_modules/next/image.js
+      var next_image = __webpack_require__(4077);
       var image_default = /*#__PURE__*/ __webpack_require__.n(next_image); // CONCATENATED MODULE: ./pages/nextjs.png
       /* harmony default export */ const nextjs = {
         src: "/_next/static/media/nextjs.cae0b805.png",
@@ -1030,12 +1030,12 @@
       /***/
     },
 
-    /***/ 8301: /***/ (
+    /***/ 4077: /***/ (
       module,
       __unused_webpack_exports,
       __webpack_require__
     ) => {
-      module.exports = __webpack_require__(1212);
+      module.exports = __webpack_require__(9894);
 
       /***/
     },
@@ -1045,7 +1045,7 @@
     /******/ var __webpack_exec__ = (moduleId) =>
       __webpack_require__((__webpack_require__.s = moduleId));
     /******/ __webpack_require__.O(0, [2888, 9774, 179], () =>
-      __webpack_exec__(2463)
+      __webpack_exec__(3353)
     );
     /******/ var __webpack_exports__ = __webpack_require__.O();
     /******/ _N_E = __webpack_exports__;
Diff for 882-HASH.js

Diff too large to display

Diff for main-HASH.js

Diff too large to display

Commit: 644f5a9

@ijjk ijjk added the tests label Sep 19, 2024
@sokra
Introduce VcOperation that wraps operations
0b54b52 
only expose VcOperation into JS to connect to the whole compution (and be strongly consistent with the whole compuation).
@sokra
fix query string
e7aa30c
@sokra
fix todo
aff79a2
@sokra
update snapshot and test case
644f5a9
@mischnic
Copy link
Contributor

Some docs would be nice. I wouldn't know when to use VcOperation instead of Vc and what .connect() actually does

@bgw bgw mentioned this pull request Sep 24, 2024
Merged
bgw added a commit that referenced this pull request Sep 24, 2024
@bgw
chore(gitattributes): Mark more __snapshots__ directories as generated (
a926b56 
#70421)

Noticed these files while reviewing #70242

Mark them as generated so that github & graphite collapse them when reviewing code.

```
$ git ls-files | git check-attr -a --stdin | grep __snapshots__
```

```
.config/ast-grep/rule-tests/__snapshots__/no-context-snapshot.yml: linguist-generated: true
examples/with-jest-babel/__tests__/__snapshots__/snapshot.tsx.snap: linguist-generated: true
examples/with-jest/__tests__/__snapshots__/snapshot.tsx.snap: linguist-generated: true
examples/with-typescript-graphql/test/__snapshots__/index.test.tsx.snap: linguist-generated: true
test/development/acceptance-app/__snapshots__/ReactRefreshLogBox.test.ts.snap: linguist-generated: true
test/development/acceptance/__snapshots__/ReactRefreshLogBox.test.ts.snap: linguist-generated: true
test/development/acceptance/__snapshots__/ReactRefreshLogBoxMisc.test.ts.snap: linguist-generated: true
test/development/acceptance/__snapshots__/error-recovery.test.ts.snap: linguist-generated: true
test/development/basic/__snapshots__/next-rs-api.test.ts.snap: linguist-generated: true
test/production/eslint/test/__snapshots__/next-build-and-lint.test.ts.snap: linguist-generated: true
```
bgw
bgw approved these changes Sep 24, 2024
View reviewed changes
turbopack/crates/turbo-tasks/src/vc/operation.rs
Comment on lines +22 to +23
// TODO to avoid this runtime check, we should mark functions with `(operation)` and return
// a VcOperation directly
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 We should figure out a way of enforcing not only that the Vc is non-local, but that the function that created it is marked with operation.

Otherwise, it won't be safe for us to automatically start converting tasks to local tasks: They might start failing this runtime assertion.

turbopack/crates/turbo-tasks/src/vc/operation.rs
///
/// The caller must ensure that the `Vc` is not a local task and it points to a a single
/// operation.
pub fn new(node: Vc<T>) -> Self {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For ResolvedVc, I'm not exposing a public constructor, and I'm instead exposing a .to_resolved() method on Vc. We should probably figure out which pattern we want to use for consistency.

turbopack/crates/turbo-tasks/src/vc/operation.rs
impl<T: ?Sized + Send> VcOperation<T> {
/// Creates a new `VcOperation` from a `Vc`.
///
/// The caller must ensure that the `Vc` is not a local task and it points to a a single
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// The caller must ensure that the `Vc` is not a local task and it points to a a single
/// The caller must ensure that the `Vc` is not a local task and it points to a single

turbopack/crates/turbo-tasks/src/vc/operation.rs
Self { node }
}

pub fn connect(self) -> Vc<T> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have some documentation about how and where it should be used.

turbopack/crates/turbo-tasks/src/vc/operation.rs
use crate::{trace::TraceRawVcs, CollectiblesSource, RawVc, TaskInput, Upcast, Vc, VcValueTrait};

#[must_use]
pub struct VcOperation<T>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have some documentation about how and where it should be used.

turbopack/crates/turbo-tasks/src/vc/operation.rs
Comment on lines +36 to +39
/// Returns the `RawVc` corresponding to this `Vc`.
pub fn into_raw(vc: Self) -> RawVc {
vc.node.node
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also deref to Vc? Or do you want the conversions to happen through .connect()?

turbopack/crates/turbo-tasks/src/vc/operation.rs
// TODO to avoid this runtime check, we should mark functions with `(operation)` and return
// a VcOperation directly
assert!(
!node.is_local(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it valid for a VcOperation to be a resolved cell? Does it have to be a function output?

test/development/basic/__snapshots__/next-rs-api.test.ts.snap
@@ -1,58 +1,1374 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing the gitattributes for these files in #70421 so that this gets collapsed in code reviews.

crates/next-api/src/operation.rs
Comment on lines +87 to +101
#[turbo_tasks::function]
fn wrap_endpoint(
endpoint: Vc<Box<dyn Endpoint>>,
op: VcOperation<Entrypoints>,
) -> Vc<Box<dyn Endpoint>> {
let _ = op.connect();
endpoint
}

fn wrap(
endpoint: Vc<Box<dyn Endpoint>>,
op: VcOperation<Entrypoints>,
) -> VcOperation<Box<dyn Endpoint>> {
VcOperation::new(wrap_endpoint(endpoint, op))
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably not worth it given the very limited number of VcOperations in existence, but we could modify #[turbo_tasks::function] to allow returning a VcOperation directly.

bgw
bgw reviewed Sep 24, 2024
View reviewed changes
Copy link
Member

@bgw bgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're going to allow #[turbo_tasks::value]s to store VcOperation, we're going to need to make it impl ResolvedValue.

However, that doesn't really seem right because a VcOperation is not truly "resolved".

What I care about for local tasks is just that this is non-local, so the questions are:

  • Should we rename ResolvedValue? What should we rename it to? NonLocalValue?
  • Is there a reason we might want ResolvedValue in the future? If so, we can keep it around and just make NonLocalValue a supertrait of ResolvedValue?

@bgw Graphite App
Copy link
Member

bgw commented Sep 24, 2024

Some docs would be nice. I wouldn't know when to use VcOperation instead of Vc and what .connect() actually does

Yeah, I agree. It's pretty confusing to me too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgw bgw bgw approved these changes

Assignees
No one assigned
Labels
created-by: Turbopack team PRs by the Turbopack team. tests Turbopack Related to Turbopack with Next.js.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sokra @ijjk @mischnic @bgw