Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated the example of with-videojs to utilize the App Router #70226

Merged
merged 5 commits into from
Sep 18, 2024
Merged

updated the example of with-videojs to utilize the App Router #70226

merged 5 commits into from
Sep 18, 2024
+48 −22

Conversation

Sam-Phillemon9493
Copy link
Contributor

@Sam-Phillemon9493 Sam-Phillemon9493 commented Sep 18, 2024 •
edited
Loading

This PR updates the with-videojs example to use the App Router. Here are the changes that have been made:

  • Renamed the pages folder to the app folder.
  • Updated the routing for / files to align with the App Router.
  • Added the layout.tsx file as part of the App Router.
  • Updated the package.json file.

The following actions were performed as part of this PR:

  • Ran pnpm prettier-check with no issues found.
  • Executed the pnpm check-examples script.

CC: @samcx

@ijjk ijjk added the examples Issue/PR related to examples label Sep 18, 2024
@ijjk
Copy link
Member

ijjk commented Sep 18, 2024 •
edited by samcx
Loading

Allow CI Workflow Run

  • approve CI run for commit: 088a14e

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@Sam-Phillemon9493 Sam-Phillemon9493 marked this pull request as ready for review September 18, 2024 16:47
@socket-security Socket Security
Copy link

socket-security bot commented Sep 18, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/video.js@8.18.1 None +11 35.8 MB videojs-user
npm/videojs-youtube@3.0.1 None 0 47.2 kB gkatsev

🚮 Removed packages: npm/video.js@7.21.6, npm/videojs-youtube@2.6.1

View full report↗︎

@samcx samcx self-requested a review September 18, 2024 21:18
samcx
samcx reviewed Sep 18, 2024
View reviewed changes
Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a PR!

:lgtm:

@samcx samcx self-requested a review September 18, 2024 21:18
@samcx samcx enabled auto-merge (squash) September 18, 2024 21:19
@samcx samcx merged commit cc8b809 into vercel:canary Sep 18, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samcx samcx samcx approved these changes

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sam-Phillemon9493 @ijjk @samcx