Allow CI Workflow Run

• approve CI run for commit: 8f14e57

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

If you have more trailing slashes, even standard util will treat them as part of pathname, sounds correct it was thrown as invalid URL?

new URL('https://fooo.com//').pathname
>> '//'

@huozhi
Thank you for your reply.

Yes, but it doesn't happen in your example...

It occurs with the following pattern (this is the code pattern used within /packages/next/src/shared/lib/router/utils/as-path-to-search-params.ts):

new URL(asPath, 'http://n').searchParams

The following error should be thrown:

Uncaught TypeError: Failed to construct 'URL': Invalid URL

Screenshot:

V8 (Blink), SpiderMonkey (Gecko) and JavaScriptCore (WebKit) all have the same behavior.

Initially, I thought that changing

new URL(asPath, 'https://n.com').searchParams

to

new URL(`https://n.com${asPath}`).searchParams

would complete the fix.

However, when I investigated deeper, I started to think that the fundamental solution might not be solved unless I changed getURL().

The reason is that the return value of getURL() is different for http:// and https://.

• If we execute now getURL() on http://n.com//, / will be returned
• If we execute now getURL() on https://n.com//, // will be returned

By fixing the core part, we can avoid problems that may occur in other code that uses the result of getURL().

The test seem cannot demostrate the issue you describe, if I manually run in https mode and just visit the page, it looks working correctly 🤔

Oh, after splitting the test file into http and https, the e2e test is now working.

If you git pull the latest commit and run the following command, it does what I want:

pnpm build && pnpm test-start test/e2e/invalid-url-slash

I'm very sorry.

Tests are passed regardless we have the changes

@huozhi
Thanks to reply.

I also confirmed that the e2e test did not fail using the old code.

Then I remembered that the case I encountered was a Pages Router, not an App Router.

When I rewrote the e2e test using Pages Router, changed utils.ts to its pre-patch state, and checked again, the e2e test failed.

After applying the patch to utils.ts, the e2e test now passes.

Thank you for making me realize that.

I have pushed the latest code, so please test it yourself 🙏