Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the example of with-vercel-fetch to utilize the App Router. #70069

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

PapatMayuri
Copy link
Contributor

This PR updates the with-vercel-fetch example for using the App Router.
Here are the changes that have been made:

  • Renamed the "pages" folder to the "app" folder.
  • Added the layout.tsx file as part of the App Router.
  • Updated the package.json file.

CC: @samcx

@ijjk ijjk added the examples Issue/PR related to examples label Sep 13, 2024
@ijjk
Copy link
Member

ijjk commented Sep 13, 2024

Allow CI Workflow Run

  • approve CI run for commit: edfbbf5

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@darthmaim
Copy link
Contributor

https://github.com/vercel/fetch is archived, so it might make more sense to just get rid of this example.

@PapatMayuri PapatMayuri marked this pull request as ready for review September 16, 2024 05:57
@PapatMayuri
Copy link
Contributor Author

@samcx Any change needed for this PR?

@samcx
Copy link
Member

samcx commented Sep 24, 2024

@PapatMayuri Let's get rid of this example! I don't think it's necessary to have an example just for fetch.

@PapatMayuri
Copy link
Contributor Author

PapatMayuri commented Sep 24, 2024

Okay, @samcx I will close the PR.

@PapatMayuri
Copy link
Contributor Author

https://github.com/vercel/fetch is archived, so closing the PR.

@samcx samcx reopened this Sep 24, 2024
@samcx
Copy link
Member

samcx commented Sep 24, 2024

@PapatMayuri We should to delete the example, not close this PR. I'll go ahead and make the changes!

@samcx samcx self-requested a review September 24, 2024 18:30
@samcx samcx merged commit ac799c3 into vercel:canary Sep 24, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants