Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the example of with-draft-js to utilize the App Router. #70045

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

PapatMayuri
Copy link
Contributor

@PapatMayuri PapatMayuri commented Sep 12, 2024

This PR updates the with-draft-js example for using the App Router.
Here are the changes that have been made:

  • Renamed the "pages" folder to the "app" folder.
  • Added the layout.tsx file as part of the App Router.
  • Updated the package.json file.

CC: @samcx

@ijjk ijjk added the examples Issue/PR related to examples label Sep 12, 2024
@ijjk
Copy link
Member

ijjk commented Sep 12, 2024

Allow CI Workflow Run

  • approve CI run for commit: 2afc658

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

1 similar comment
@ijjk
Copy link
Member

ijjk commented Sep 12, 2024

Allow CI Workflow Run

  • approve CI run for commit: 2afc658

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@PapatMayuri PapatMayuri marked this pull request as ready for review September 13, 2024 08:48
@PapatMayuri
Copy link
Contributor Author

@samcx Any changes needed for this PR?

@samcx
Copy link
Member

samcx commented Sep 24, 2024

@PapatMayuri Let's delete this example. The package draft-js has been archived for a while → https://github.com/facebookarchive/draft-js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants