Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing properties in Manifest type (screenshots) #62161

Open
maphe opened this issue Feb 16, 2024 · 3 comments
Open

Missing properties in Manifest type (screenshots) #62161

maphe opened this issue Feb 16, 2024 · 3 comments
Labels
Documentation Related to Next.js' official documentation.

Comments

@maphe
Copy link

maphe commented Feb 16, 2024

What is the improvement or update you wish to see?

I opened a regular issue but it got closed, so trying here...

https://github.com/vercel/next.js/blob/canary/packages/next/src/lib/metadata/types/manifest-types.ts#L54

screenshots[].form_factor is not available in the type MetadataRoute.Manifest. narrow or wide should be the 2 allowed values

That's just one value missing from the type, it is also missing label and platform in screenshots

Is there any context that might help us understand?

https://developer.mozilla.org/en-US/docs/Web/Manifest/screenshots

Does the docs page already exist? Please link to it.

No response
@maphe maphe added the Documentation Related to Next.js' official documentation. label Feb 16, 2024
@titan-rocky titan-rocky mentioned this issue Feb 18, 2024
Merged
@ViKi10000
Copy link

can i work on this?

@redbmk redbmk mentioned this issue Aug 2, 2024
Closed
redbmk added a commit to redbmk/next.js that referenced this issue Aug 2, 2024
@redbmk
fix: update screenshot manifest types
efba8d6 
Updates the `screenshots` section of `MetadataRoute.Manifest` to include
`form_factor`, `label`, and `platform`, per the spec

fixes: vercel#62161
refs: https://w3c.github.io/manifest-app-info/#screenshots-member
refs: https://developer.mozilla.org/en-US/docs/Web/Manifest/screenshots
@redbmk
Copy link
Contributor

redbmk commented Aug 2, 2024

This will be fixed in #68273

@sahandsn
Copy link

when can this be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation Related to Next.js' official documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: update screenshot manifest types redbmk/next.js
4 participants
@redbmk @maphe @sahandsn @ViKi10000