Update use-router.mdx #57273
Merged
Update use-router.mdx #57273
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor tweak to the wording of this section to better convey the behavior of "scroll: false"
alessiomaffeis
requested review from
timeyoutakeit and
StephDietz
and removed request for
a team
balazsorban44
added
Documentation
|
Any thoughts on this? @timeyoutakeit @StephDietz |
ijjk
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor tweak to the wording of this section to better convey the behavior of
scroll: false."Restoration" can be interpreted as reinstating a previously saved scroll position for that route (as it happens when using
router.back()), while what it actually does is preserving the current scroll position when navigating to a new route, by means of disabling the default "scroll to top" behavior.Related to: #57258, and #47781 (reply in thread)